Issue #2494 Renamed backtrack variables to lookahead #2499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
reviewed
Feb 17, 2024
Sources/SwiftParser/Statements.swift
Outdated
Comment on lines
211
to
212
| // lookahead + lookaheading on simple if conditions that are obviously | ||
| // boolean conditions. |
There was a problem hiding this comment.
Suggested change
| // lookahead + lookaheading on simple if conditions that are obviously | |
| // boolean conditions. | |
| // lookahead on simple if conditions that are obviously boolean conditions. |
There was a problem hiding this comment.
Thank you for your suggestion regarding the comments on lines 211 to 212 in Statements.swift. I've made the requested modification as per your recommendation.
|
Oh, one last thing. Could you squash your commits? https://github.com/apple/swift-syntax/blob/main/CONTRIBUTING.md#authoring-commits |
Updated comment in Sources/SwiftParser/Statements.swift
dhruvviee
force-pushed
the
backtrack-lookahead-#2494
branch
from
6522f3c to
aa0e131
Compare
|
Hi, @ahoppen |
ahoppen
approved these changes
Feb 19, 2024
|
@swift-ci Please test |
|
Test failures are unrelated. Let’s try again @swift-ci Please test |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2494